Messages in this thread | | | Date | Thu, 6 Jul 2006 10:31:34 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/6] FRV: Fix FRV arch compile errors [try #3] |
| |
On Thu, 06 Jul 2006 13:47:21 +0100 David Howells <dhowells@redhat.com> wrote:
> --- a/include/linux/bootmem.h > +++ b/include/linux/bootmem.h > @@ -91,7 +91,7 @@ static inline void *alloc_remap(int nid, > } > #endif > > -extern unsigned long nr_kernel_pages; > +extern unsigned long __initdata nr_kernel_pages;
- The __init-style tags on declarations don't actually do anything and the compiler doesn't check for consistency with the definition - it's best to just omit it from the declaration.
- Setting nr_kernel_pages to be unloaded at free_initmem() seems risky.
- nr_kernel_pages is actually __meminitdata.
So I'll drop this hunk. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |