lkml.org 
[lkml]   [2006]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86-64 TIF flags for debug regs and io bitmap in ctxsw
Arjan,

On Tue, Jul 04, 2006 at 09:51:49AM +0200, Arjan van de Ven wrote:
> > - }
> > - }
> > + if (unlikely((task_thread_info(next_p)->flags & _TIF_WORK_CTXSW))
> > + || test_tsk_thread_flag(prev_p, TIF_IO_BITMAP))
> > + __switch_to_xtra(prev_p, next_p, tss);
>
> well isn't this replacing an if() (which isn't cheap but also not
> expensive, due to unlikely()) with an atomic operation (which *is*
> expensive) ?
>
Andi is right. I double checked the test_tsk_thread_flag() and it does not
use atomic ops.

--
-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-04 10:24    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site