Messages in this thread | | | Date | Tue, 04 Jul 2006 09:38:49 -0700 | From | Zach Brown <> | Subject | Re: [openib-general] [PATCH] mthca: initialize send and receive queue locks separately |
| |
> This moves code out of a common function and so results in code duplication > and has memory cost.
Of course. I don't care which trade-offs you prefer to maintain as long as the driver stops yelling at me as the machine boots. That patch was what Arjan suggested as the simplest.
Also, while looking at this I saw that the locks are being re-initialized from mthca_modify_qp(). Is that just a side-effect of relying on mthca_wq_init() to reset the non-lock members? If you're concerned about microoptimization it seems like this could be avoided.
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |