Messages in this thread | | | Date | Mon, 31 Jul 2006 14:18:00 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [linux-usb-devel] [PATCH] Properly unregister reboot notifier in case of failure in ehci hcd |
| |
On Mon, 31 Jul 2006, Aleksey Gorelov wrote:
> If some problem occurs during ehci startup, for instance, request_irq fails, echi hcd driver > tries it best to cleanup, but fails to unregister reboot notifier, which in turn leads to crash on > reboot/poweroff. The following patch resolves this problem by not using reboot notifiers anymore, > but instead making ehci/ohci driver get its own shutdown method. For PCI, it is done through pci > glue, for everything else through platform driver glue.
Why do you need to change the bus glue? Wouldn't it be a lot simpler just to add ehci_shutdown as a member of ehci_pci_driver, for instance, with similar changes to ehci_hcd_au1xxx_driver and ehci_hcd_fsl_driver?
Alan Stern
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |