Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH 005 of 9] md: Replace magic numbers in sb_dirty with well defined bit flags | Date | Mon, 31 Jul 2006 17:33:11 +0200 |
| |
Hi Neil,
I think the names in this patch don't match the description at all. May I suggest different ones?
On Monday, 31. July 2006 09:32, NeilBrown wrote: > > Instead of magic numbers (0,1,2,3) in sb_dirty, we have > some flags instead: > MD_CHANGE_DEVS > Some device state has changed requiring superblock update > on all devices.
MD_SB_STALE or MD_SB_NEED_UPDATE
> MD_CHANGE_CLEAN > The array has transitions from 'clean' to 'dirty' or back, > requiring a superblock update on active devices, but possibly > not on spares
Maybe split this into MD_SB_DIRTY and MD_SB_CLEAN ?
> MD_CHANGE_PENDING > A superblock update is underway.
MD_SB_PENDING_UPDATE
Regards
Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |