lkml.org 
[lkml]   [2006]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] making the kernel -Wshadow clean - fix mconf
Jesper wrote:
> - cprint("%s", filename);
> + cprint("%s", config_filename);

Something seems strange here to me. It looks like you are sometimes
resolving the shadowed symbols by making the more local symbol have the
longer name.

I'd have expected that the global symbol would be the one with the
longer, more elaborate name.

In other words, I would have expected that we would avoid having global
names such as (from your other patches in this set):

filename
scroll
instr
up
sum
state
rep
complete
irq

Perhaps I am misreading this patch set?

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-30 20:37    [from the cache]
©2003-2011 Jasper Spaans