Messages in this thread | | | Subject | Re: [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk | From | Trond Myklebust <> | Date | Sun, 30 Jul 2006 12:12:21 -0400 |
| |
On Sat, 2006-07-29 at 23:26 -0700, Andrew Morton wrote: > On Sun, 30 Jul 2006 00:22:14 -0400 > Trond Myklebust <trond.myklebust@fys.uio.no> wrote: > > > > of course, it could be that some quirk of the NFS client VFS interface > > > causes "spurious" -EIO returns. either way, i'd rather see it fixed > > > rather than the printk removed, since it is useful to point out that > > > some performance degradation is occuring. > > > > We have no way of telling. That printk doesn't give us any useful > > information whatsoever for debugging that sort of problem. It should > > either be replaced with something that does, or it should be thrown out. > > err, the printk has found a probable bug in NFS. That was pretty useful > of it.
Not necessarily. AFAICS, the spam could be triggered by perfectly legitimate activity. For instance, someone on the server may have revoked your read permissions to the file, or may have deleted it.
> Do we know why nfs's readpage isn't bringing the page up to date?
It may be that other lurking issues were also triggering the printk. For instance I know of a couple of corner cases in the krb5 privacy code that could result in readpage failing. Those issues are being looked into.
Cheers, Trond
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |