Messages in this thread | | | Date | Sun, 30 Jul 2006 11:17:47 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [discuss] [Patch] 2/5 in support of hot-add memory x86_64 create arch_find_node |
| |
On Sat, 29 Jul 2006 18:25:15 +0200 Andi Kleen <ak@suse.de> wrote:
> On Saturday 29 July 2006 04:52, keith mannthey wrote: > > With the advent of the new ACPI hot-plug memory driver and mechanism > > is needed to deal with ACPI add memory events that do not contain the > > pxm (node) information. I do not believe that the add-event is required > > to contain this information so I create a arch_find_node generic layer > > used in the generic add_memory function. > > > > If add_memory is called with node < 0 arch_find_node is invoked to > > fine the correct node to add the memory. This created the generic > > construct of arch_find_node. > > It would be cleaner to always call add_memory from architecture specific > code instead of such ugly hooks > Hi, Keith
I don't like insert such a check (nid < 0) in add_memory(), either. Could you add it before calling add_memory() ? (for example, find_pxm parh in acpi's add memory code.)
-Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |