lkml.org 
[lkml]   [2006]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [KJ] audit return code handling for kernel_thread [1/11]
nhorman@tuxdriver.com wrote:
> Audit/Cleanup of kernel_thread calls, specifically checking of return codes.
> Problems seemed to fall into 3 main categories:
>

Thanks for doing this. Nitpick: this should be all one patch, or at most 3
patches (then each of the below 3 items would become individual changelogs).

Each patch should have a unique changelog, each should have a unique subject
(sans the sequence number).

cc'ing Andrew is also a good idea, if you want them to get merged ;)

One coding style comment:
if (...)
multi line
statement

Could use braces around the outermost if statement, for clarity.


> 1) callers of kernel_thread were inconsistent about meaning of a zero return
> code. Some callers considered a zero return code to mean success, others took
> it to mean failure. a zero return code, while not actually possible in the
> current implementation, should be considered a success (pid 0 is/should be
> valid). fixed all callers to treat zero return as success
>
> 2) caller of kernel_thread saved return code of kernel_thread for later use
> without ever checking its value. Callers who did this tended to assume a
> non-zero return was success, and would often wait for a completion queue to be
> woken up, implying that an error (negative return code) from kernel_thread could
> lead to deadlock. Repaired by checking return code at call time, and setting
> saved return code to zero in the event of an error.
>
> 3) callers of kernel_thread never bothered to check the return code at all.
> This can lead to seemingly unrelated errors later in execution. Fixed by
> checking return code at call time and printing a warning message on failure.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-29 01:51    [W:0.040 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site