Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [patch 1/2] i386: add CFI macros for stack manipulation | Date | Fri, 28 Jul 2006 20:36:45 +0200 |
| |
On Friday 28 July 2006 19:50, Chuck Ebbert wrote: > Add macros to dwarf2.h to simplify pushing and popping stack > variables.
I feared someone would do that patch. I've thought about it myself.
However it's not a good idea. I've already had complaints that some code in x86-64 is too hard to read/debug because it uses too many macros. I think it's better if the core core still uses "real" instructions and keep the CFI_* stuff as annotation that most people can just ignore.
With your change that wouldn't be the case and everybody hacking the code would need to know all of CFI too, which is still quite arcane stuff.
So while it would make the source shorter and require less typing I don't think it's good for readability.
What would be a good thing if someone could write it up would be a short tutorial for Documentation/* on CFI
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |