Messages in this thread | | | Date | Thu, 27 Jul 2006 23:14:55 -0400 | From | Josef Sipek <> | Subject | Re: [PATCH] Some const for linux/time.h |
| |
On Thu, Jul 27, 2006 at 10:40:47PM +0200, Jan Engelhardt wrote: > Hello, > > > time compare functions do not modify their arguments, so they can > be marked as const (like some of the functions in time.h are already). > > Signed-off-by: Jan Engelhardt <jengelh@gmx.de> > > diff --fast -Ndpru linux-2.6.17.7~/include/linux/time.h linux-2.6.17.7+/include/linux/time.h > --- linux-2.6.17.7~/include/linux/time.h 2006-06-06 02:57:02.000000000 +0200 > +++ linux-2.6.17.7+/include/linux/time.h 2006-07-27 22:35:53.308571000 +0200 > @@ -33,7 +33,8 @@ struct timezone { > #define NSEC_PER_SEC 1000000000L > #define NSEC_PER_USEC 1000L > > -static inline int timespec_equal(struct timespec *a, struct timespec *b) > +static inline int timespec_equal(const struct timespec *a, > + const struct timespec *b)
As per CodingStyle, the second line should be "placed substantially to the right."
Josef Sipek.
-- Humans were created by water to transport it upward. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |