lkml.org 
[lkml]   [2006]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: lockdep: results on ARM
Arjan van de Ven wrote:
> On Thu, 2006-07-27 at 15:24 +0100, Russell King wrote:
>> +#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
>> + p->hardirqs_enabled = 1;
>> +#else
>> p->hardirqs_enabled = 0;
>> +#endif
>
> if __ARCH_WANT_INTERRUPTS_ON_CTXSW is set to 1 for arm you can turn this
> into
>
> p->hardirqs_enabled = __ARCH_WANT_INTERRUPTS_ON_CTXSW + 0;
>
> and save the ifdef ;)
>

#ifdef is actually really evil. It's much cleaner to use #if and make
sure everything defines either 0 or 1. Partially because it often makes
you not have to add an #if at all, but also because it makes it
immediately obvious if some definition was missed.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-27 22:53    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean