Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] ncpfs: move ioctl32 code to fs/ncpfs/ioctl.c | Date | Thu, 27 Jul 2006 07:45:41 +0200 |
| |
On Thursday 27 July 2006 05:35, Petr Vandrovec wrote: > Yes, tomorrow (on amd64).
No need to hurry, I was sitting on my patch for more than a year now ;-)
> Although I understand that this code is correct, what about removing this second > #ifdef ? gcc should realize it anyway that without CONFIG_COMPAT defined cmd > must be equal to NCP_IOC_GETPRIVATEDATA, and having empty "else" variant is IMHO > just asking for troubles.
That was what I did first, but unfortunately we don't define compat_caddr_t when CONFIG_COMPAT is disabled, so it would reference an invalid data structure.
> Or what about > > #ifdef CONFIG_COMPAT > if (cmd == NCP_IOC_GETPRIVATEDATA_32) { > struct ... > } else > #endif > if (copy_to_user(argp, &user, sizeof(user))) > return -EFAULT;
Yes, that should be clearer than my approach.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |