Messages in this thread | | | Date | Wed, 26 Jul 2006 14:21:02 -0700 | From | Srivatsa Vaddagiri <> | Subject | Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare |
| |
On Wed, Jul 26, 2006 at 11:03:06PM +0200, Arjan van de Ven wrote: > rwsems unfortunately help you zilch; an rwsem is just a mutex with a > performance tweak, but from the deadlock perspective it's really a > mutex.
ah ..didnt realize that.
> I'm really starting to feel that the hotplug lock would have been better > of being a refcount (with a waitqueue for zero) than a lock. While > "refcount+waitqueue" sort of IS a lock, the semantics make more sense > imo...
I think that will work, although you now need to deal with a global or per-cpu refcount now. Later is more cache-friendly, but dont think we have ready refcounting APIs for that?
-- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |