lkml.org 
[lkml]   [2006]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/2] slab: always consider arch mandated alignment
    Pekka J Enberg wrote:

    >On Wed, 26 Jul 2006, Heiko Carstens wrote:
    >
    >
    >>We only specify ARCH_KMALLOC_MINALIGN, since that aligns only the kmalloc
    >>caches, but it doesn't disable debugging on other caches that are created
    >>via kmem_cache_create() where an alignment of e.g. 0 is specified.
    >>
    >>The point of the first patch is: why should the slab cache be allowed to chose
    >>an aligment that is less than what the caller specified? This does very likely
    >>break things.
    >>
    >>
    >
    >Ah, yes, you are absolutely right. We need to respect caller mandated
    >alignment too. How about this?
    >
    >
    >
    Good catch - I obviously never tested the code for an HWCACHE_ALIGN cache...


    > Pekka
    >
    >[PATCH] slab: respect architecture and caller mandated alignment
    >
    >Ensure cache alignment is always at minimum what the architecture or
    >caller mandates even if slab debugging is enabled.
    >
    >Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
    >
    >
    Signed-off-by: Manfred Spraul <manfred@colorfullife.com>

    --
    Manfred
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-26 20:11    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean