Messages in this thread | | | Subject | Re: [NFS] [PATCH 002 of 9] knfsd: knfsd: Remove an unused variable from e_show(). | From | Greg Banks <> | Date | Tue, 25 Jul 2006 14:24:56 +1000 |
| |
On Tue, 2006-07-25 at 14:20, Neil Brown wrote: > On Tuesday July 25, jsipek@fsl.cs.sunysb.edu wrote: > > On Tue, Jul 25, 2006 at 11:54:32AM +1000, NeilBrown wrote: > > ... > > > diff .prev/fs/nfsd/export.c ./fs/nfsd/export.c > > > --- .prev/fs/nfsd/export.c 2006-07-24 14:33:06.000000000 +1000 > > > +++ ./fs/nfsd/export.c 2006-07-24 14:33:26.000000000 +1000 > > > @@ -1178,7 +1178,6 @@ static int e_show(struct seq_file *m, vo > > ... > > > if (p == (void *)1) { > > > > I'm not an NFS expert, but the above makes me want to puke. Isn't there a > > cleaner way of doing whatever needs to be done without: > > > > 1) hard-coding a constant > > 2) comparing a variable to an arbitrary pointer > > > > Probably. We just need a pointer value that is definitely not a > pointer to a valid cache_head object, and is not NULL. > (void*)1 seems a reasonable choice, but maybe #defineing something > would help.
include/linux/seq_file.h:
#define SEQ_START_TOKEN ((void *)1)
Greg. -- Greg Banks, R&D Software Engineer, SGI Australian Software Group. I don't speak for SGI.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |