lkml.org 
[lkml]   [2006]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] OMAP: Add keypad driver #2
On 7/25/06, Komal Shah <komal_shah802003@yahoo.com> wrote:
> Andrew/Tony/Richard,
>
> This is a revised patch as per the review comments from the Andrew
> on thread:
>
> http://lkml.org/lkml/2006/7/22/19
>
> Please review it and give me the Ack if looks ok.
>

Hi Komal,

The driver needs to handle failures in input_register_device() and
unwind initialization properly. Also you do not need to do double
negation of the value when calling input_report_key() because it will
do it for you.

Also you might consider setting up keycodetable, keycodesize, etc in
the input device - this way you can change keymap at runtime via
ioctls.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-25 22:35    [W:0.053 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site