lkml.org 
[lkml]   [2006]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectntfs: remove unnecessary PG_uptodate check from ntfs_readpage
From: Pekka Enberg <penberg@cs.helsinki.fi>

The check is not needed because SetPageUptodate is called for locked pages
and callers of ->readpage either explicitly check for PageUptodate or pass
newly allocated pages (see read_cache_pages and page_cache_read).

Cc: Andrew Morton <akpm@osdl.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---

fs/ntfs/aops.c | 8 --------
1 file changed, 8 deletions(-)

Index: 2.6/fs/ntfs/aops.c
===================================================================
--- 2.6.orig/fs/ntfs/aops.c
+++ 2.6/fs/ntfs/aops.c
@@ -410,14 +410,6 @@ static int ntfs_readpage(struct file *fi

retry_readpage:
BUG_ON(!PageLocked(page));
- /*
- * This can potentially happen because we clear PageUptodate() during
- * ntfs_writepage() of MstProtected() attributes.
- */
- if (PageUptodate(page)) {
- unlock_page(page);
- return 0;
- }
vi = page->mapping->host;
ni = NTFS_I(vi);
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-07-25 14:47    [W:0.053 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site