Messages in this thread | | | Date | Mon, 24 Jul 2006 17:12:13 -0700 | From | Stephen Hemminger <> | Subject | Re: softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] |
| |
On Tue, 25 Jul 2006 01:00:54 +0100 Daniel Drake <dsd@gentoo.org> wrote:
> Tom Walter Dillig wrote: > > [109] > > 452 net/ieee80211/softmac/ieee80211softmac_io.c > > Possible null dereference of variable "*pkt" in function call > > (include/asm/string.h:__constant_c_and_count_memset) checked at > > (453:net/ieee80211/softmac/ieee80211softmac_io.c) > > Either I'm misunderstanding, or this is bogus. > > when *pkt is allocated by the various child functions (e.g. > ieee80211softmac_disassoc_deauth), it is always checked for NULL. > > Finally, line 453 does another NULL check.
> > What is the report trying to say?
That the check in 453 should be removed because is unneeded.
People who obsess about code coverage care that there are unneded checks. I don't think it matters. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |