lkml.org 
[lkml]   [2006]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] [coda] Remove incorrect unlock_kernel from allocation failure path in coda_open
From
Date
Commit 398c53a757702e1e3a7a2c24860c7ad26acb53ed (in the historical GIT tree)
moved the lock_kernel() in coda_open after the allocation of a coda_file_info
struct, but left an unlock_kernel() in the allocation failure error path;
remove it.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
---
fs/coda/file.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/fs/coda/file.c b/fs/coda/file.c
index cc66c68..dbfbcfa 100644
--- a/fs/coda/file.c
+++ b/fs/coda/file.c
@@ -136,10 +136,8 @@ int coda_open(struct inode *coda_inode,
coda_vfs_stat.open++;

cfi = kmalloc(sizeof(struct coda_file_info), GFP_KERNEL);
- if (!cfi) {
- unlock_kernel();
+ if (!cfi)
return -ENOMEM;
- }

lock_kernel();


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-24 23:27    [W:0.296 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site