lkml.org 
[lkml]   [2006]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: remove pci domain local copy (02/07)

> I would presume that hose goes away too?

Well not yet as I used it below...
>
>> +static inline int drm_get_pci_domain(struct drm_device *dev)
>> +{
>> +#ifdef __alpha__
>> + return dev->hose->bus->number;
>> +#else
>> + return 0;
>> +#endif
>> +}
>
> Please use the always-present pci_domain_nr() rather than inventing a
> DRM-specific function that does the same thing.

Ah well I didn't know that existed, I merely was just moving some code in
the DRM into another function in the DRM, it didn't occur that someone
might have a generic function and not put it into the DRM code.. I'll look
into it thanks,

Dave.

--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
Linux kernel - DRI, VAX / pam_smb / ILUG

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-22 18:57    [W:0.045 / U:11.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site