lkml.org 
[lkml]   [2006]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] - sgiioc4: fixup use of mmio ops
On Wed, 19 Jul 2006 22:19:29 -0700
Jeremy Higdon <jeremy@sgi.com> wrote:

> On Wed, Jul 19, 2006 at 10:31:55AM -0500, John Keller wrote:
> > Resend #2 changes include:
> >
> > - use 'void __iomem *' for ioremap() return values,
> > and handle error cases.
> >
> > sgiioc4.c had been recently converted to using mmio ops.
> > There are still a few issues to cleanup.
> >
> > Signed-off-by: jpk@sgi.com
> Signed-off-by: jeremy@sgi.com

hrm. I think we're owed a couple of iounmap()s, please. One in the
ide_dma_sgiioc4() error path and one in the takedown path.

Maybe that was one of the "few issues to cleanup", but it's a pretty simple
one.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-21 15:21    [W:0.222 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site