Messages in this thread | | | Date | Fri, 21 Jul 2006 14:20:02 +0300 (EEST) | From | Pekka J Enberg <> | Subject | Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc. |
| |
At some point in time, I wrote: > > There are things that are almost generally agreed upon, such as > > removal of redundant typecasts, redundant wrappers, and moving > > assignment out of if statement expression. Formatting and the dreaded > > sizeof thing, however, are not, so it is best to keep them as-is.
On Fri, 21 Jul 2006, Stefan Richter wrote: > Contributors can't know what the (supposed) _agreements_ are. > > Contributors can only know what the _documented conventions_ are.
Life gets easier when you accept the fact that there are different conventions within the kernel, driven by maintainer preference. Which is why it is impossible to document a definite set of conventions too. CodingStyle really is just a good approximation what kernel code should look like. If you deviate from it too much, everyone agrees that you're violating it, but there definitely is room for maintainer preference. As a contributor, when you accept that, you'll have much greater chances of getting your patches merged.
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |