lkml.org 
[lkml]   [2006]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    From
    Date
    Hi,

    On wo, 2006-07-19 at 02:40 +0000, Daniel K. wrote:
    > > [...]
    > > diff --git a/drivers/char/rio/riocmd.c b/drivers/char/rio/riocmd.c
    > > index 4df6ab2..593940f 100644
    > > --- a/drivers/char/rio/riocmd.c
    > > +++ b/drivers/char/rio/riocmd.c
    > > @@ -556,9 +556,7 @@ struct CmdBlk *RIOGetCmdBlk(void)
    > > {
    > > struct CmdBlk *CmdBlkP;
    > >
    > > - CmdBlkP = (struct CmdBlk *)kmalloc(sizeof(struct CmdBlk), GFP_ATOMIC);
    > > - if (CmdBlkP)
    > > - memset(CmdBlkP, 0, sizeof(struct CmdBlk));
    > > + CmdBlkP = kzalloc(sizeof(struct CmdBlk), GFP_ATOMIC);
    > > return CmdBlkP;
    > > }
    > >
    >
    > Why not return kzalloc(...) here? Alternatively, return (type *) kzalloc(...),
    > if you believe in explicit type casting of void pointers.
    I figured someone might want to add extra code in f.e. RIOGetCmddBlk to
    be able to debug/modify memory allocation behavior for the RIO driver
    only. It does look a bit messy though. So I've updated it in my updated
    patch.

    Cheers,
    Takis

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-20 19:29    [W:0.027 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site