Messages in this thread | | | Date | Fri, 21 Jul 2006 03:07:24 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] Promise 'stex' driver |
| |
On Thu, Jul 20 2006, Jeff Garzik wrote: > James Bottomley wrote: > >On Thu, 2006-07-20 at 17:27 -0400, Jeff Garzik wrote: > >>Since _no individual SCSI driver_ uses the block layer > >>tagging, it is likely that some instability and core kernel > >>development > >>will occur, in order to make that work. > > > >That's not quite true: 53c700 and tmscsim both use it ... I could with > >the usage were wider, but at least 53c700 has pretty regular and > >constant usage ... enough I think to validate the block tag code (it's > >been using it for the last three years). > > Not for the case being discussed in this thread, adapter-wide tags.
That just means the map is shared, otherwise there should be little if any difference.
> AFAICS, no file in include/scsi/* or drivers/scsi/* ever calls > blk_queue_init_tags() with a non-NULL third arg.
grpe again, it's in scsi_tcq.h.
> The block tagging capability being discussed here is poorly validated > due to overall underuse, and its never been used in SCSI AFAIK.
It has and is, James uses it every day!
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |