Messages in this thread | | | Date | Wed, 19 Jul 2006 01:49:43 +0000 | From | "Daniel K." <> | Subject | Re: [PATCH 2/2] Forgotten memset |
| |
Panagiotis Issaris wrote: > --- a/drivers/scsi/ide-scsi.c > +++ b/drivers/scsi/ide-scsi.c > @@ -327,7 +327,7 @@ static int idescsi_check_condition(ide_d > > /* stuff a sense request in front of our current request */ > pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC); > - rq = kmalloc (sizeof (struct request), GFP_ATOMIC); > + rq = kzalloc (sizeof (struct request), GFP_ATOMIC); > buf = kzalloc(SCSI_SENSE_BUFFERSIZE, GFP_ATOMIC); > if (pc == NULL || rq == NULL || buf == NULL) { > kfree(buf); > > Was this forgotten and therefore, is it necessary or useful to zero this > out?
No, this code snippet is followed by a call to
ide_init_drive_cmd(rq)
which calls memset()
Daniel K.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |