Messages in this thread | ![/](/images/icornerl.gif) | | From | Andi Kleen <> | Subject | Re: [PATCH] panic_on_oops: remove ssleep() | Date | Tue, 18 Jul 2006 00:27:51 +0200 |
| |
On Monday 17 July 2006 18:17, Horms wrote: > This patch is part of an effort to unify the panic_on_oops behaviour > across all architectures that implement it. > > It was pointed out to me by Andi Kleen that if an oops has occured > in interrupt context, then calling sleep() in the oops path will only cause > a panic, and that it would be really better for it not to be in the path at > all. > > This patch removes the ssleep() call and reworks the console message > accordinly. I have a slght concern that the resulting console message is > too long, feedback welcome.
Keeping the delay might be actually useful so that you can see the panic before system reboots when reboot on panic is enabled. I would just use a loop of mdelays(1) with touch_nmi_watchdog/touch_softirq_watchdog()s inbetween.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |