[lkml]   [2006]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 01/45] XFS: corruption fix
-stable review patch.  If anyone has any objections, please let us know.

From: Mandy Kirkconnell <>

Fix nused counter. It's currently getting set to -1 rather than getting
decremented by 1. Since nused never reaches 0, the "if (!free->hdr.nused)"
check in xfs_dir2_leafn_remove() fails every time and xfs_dir2_shrink_inode()
doesn't get called when it should. This causes extra blocks to be left on
an empty directory and the directory in unable to be converted back to
inline extent mode.
Signed-off-by: Mandy Kirkconnell <>
Signed-off-by: Nathan Scott <>
Signed-off-by: Chris Wright <>
Signed-off-by: Greg Kroah-Hartman <>

fs/xfs/xfs_dir2_node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-
+++ linux-
@@ -970,7 +970,7 @@ xfs_dir2_leafn_remove(
* One less used entry in the free table.
- free->hdr.nused = cpu_to_be32(-1);
+ be32_add(&free->hdr.nused, -1);
xfs_dir2_free_log_header(tp, fbp);
* If this was the last entry in the table, we can
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-07-17 18:51    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean