lkml.org 
[lkml]   [2006]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set
    Date
    On Sunday 16 July 2006 22:47, Ingo Molnar wrote:
    > * Andi Kleen <ak@suse.de> wrote:
    > > unsigned long arch_align_stack(unsigned long sp)
    > > {
    > > - if (randomize_va_space)
    > > + if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
    > > sp -= get_random_int() % 8192;
    > > return sp & ~0xf;
    >
    > i'm not opposing this patch at all, but didnt the performance problems
    > go away when the 0xf was changed to 0x7f?

    Yes, but i sent the patch before that other patch was available.

    I guess it's a separate issue anyways - this patch is just concerned about
    disabling randomization consistently. Performance optimization can be done
    in another one.

    -Andi


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-16 23:15    [W:2.508 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site