lkml.org 
[lkml]   [2006]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] - sgiioc4: fixup use of mmio ops
John Keller wrote:
>>>> - if (!request_region(base, IOC4_CMD_CTL_BLK_SIZE, hwif->name)) {
>>>> + cmd_phys_base = bar0 + IOC4_CMD_OFFSET;
>>>> + if (!request_mem_region(cmd_phys_base, IOC4_CMD_CTL_BLK_SIZE,
>>>> + hwif->name)) {
>>>> printk(KERN_ERR
>>>> - "%s : %s -- ERROR, Port Addresses "
>>>> + "%s : %s -- ERROR, Addresses "
>>>> "0x%p to 0x%p ALREADY in use\n",
>>>> - __FUNCTION__, hwif->name, (void *) base,
>>>> - (void *) base + IOC4_CMD_CTL_BLK_SIZE);
>>>> + __FUNCTION__, hwif->name, (void *) cmd_phys_base,
>>>> + (void *) cmd_phys_base + IOC4_CMD_CTL_BLK_SIZE);
>> If 'void __iomem *' were used, no casts would be needed here
>
> So, 'void __iomem *' should also be used for physical (non-mapped)
> addresses, as in this case?


Ooops, no, just cookies returned from ioremap() and ioremap_nocache().

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-13 16:49    [W:0.056 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site