lkml.org 
[lkml]   [2006]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390 hypfs fixes for 2.6.18-rc1-mm1
Andrew Morton wrote:
> On Wed, 12 Jul 2006 21:17:53 -0700
> Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
>
>> +static ssize_t hypfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
>> + unsigned long nr_segs, loff_t offset)
>> {
>> char *data;
>> size_t len;
>> struct file *filp = iocb->ki_filp;
>> + /* XXX: temporary */
>> + char __user *buf = iov[0].iov_base;
>> + size_t count = iov[0].iov_len;
>> +
>> + if (nr_segs != 1) {
>> + count = -EINVAL;
>> + goto out;
>> + }
>>
>
> err, "temporary" things tend to become permanent. What's the real fix?
>
I am not sure, if we really need to vectorize this method or not -
meaning will this be ever called
with more than one items in the vector.

Micheal, is it possible ? Can some one directly use AIO interface on
hypfs ? If not, we can always
look at only first element and ignore rest of them. Otherwise, we need
to iterate on all the elements
of the vector.

Thanks,
Badari


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-13 16:33    [W:0.085 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site