lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] APM resume breakage from 2.6.18-rc1 clocksource changes
Hi,

On Mon, 10 Jul 2006, john stultz wrote:

> > > APM can only keep interrupts disabled on non-IBM machines, presumably
> > > due to BIOS problems.
> >
> > Is it possible to disable the timer interrupt before suspend and just
> > reinit the timer afterwards?
>
> The timer interrupt is re-enabled, via the timer_sysclass::resume hook,
> while the timekeeping code is re-enabled via the
> timekeeping_sysclass::resume hook. The issue being that I'm not sure
> there's a defined way to specify the .resume calling order.
>
> The timekeeping_suspended flag is a bit heavy handed, but I think it
> might be the safest bet (assuming Mikael finds it works for him).

As temporary measure it's ok, but please add a comment, that it's there
because of broken suspend/resume ordering.
That's another reason why I think that keeping interrupt handling and
timekeeping separate is illusionary.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-11 01:03    [from the cache]
©2003-2011 Jasper Spaans