lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: tty's use of file_list_lock and file_move
On 7/10/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> We hold file_list_lock because we have to find everyone using that tty
> and hang up their instance of it, then flip the file operations not
> because we need to protect against tty structs going away. It's needed
> in order to walk the file list and protects against the file list itself
> changing rather than the tty structs. It may well be possible to move
> that to a tty layer private lock with care, but it would need care to
> deal with VFS operations.

Assuming do_SAK has blocked anyone's ability to newly open the tty,
why does it need to search every file handle in the system instead of
just using tty->tty_files? tty->tty_files should contain a list of
everyone who has the tty open. Is this global search needed because of
duplicated handles?

--
Jon Smirl
jonsmirl@gmail.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-11 00:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site