lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing


Russell King wrote:
> On Mon, Jul 10, 2006 at 03:52:27PM -0400, Brian Walsh wrote:
>
>> If the amount of flash is not divisible by 2 then the mask in
>> parse_mtd_partitions would fail to work as designed. Passing in the
>> base address corrects this problem.
>>
>
> This patch is obviously buggy and untested. "resouce" is a typo.
>

??

Strange, not sure how that 'r' got dropped. I will resubmit it corrected.
>
>> diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
>> --- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
>> +++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 13:34:09.000000000 -0400
>> @@ -253,7 +253,7 @@
>> /* Use the fast version */
>> info->map.write = ixp4xx_write16,
>>
>> - err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
>> + err = parse_mtd_partitions(info->mtd, probes, &info->partitions,
>> dev->resouce->start);
>> if (err > 0) {
>> err = add_mtd_partitions(info->mtd, info->partitions, err);
>> if(err)
>>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-10 22:41    [W:0.072 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site