lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2.6.18-rc1 1/1] drivers/base: Platform notify needs to occur before drivers attach to the device
    The platform_notify call for Arm and PPC architectures needs to be
    called before the driver attaches to the device. The problem only
    presents itself when hotplugging certain devices while the driver is
    already loaded.


    Signed-off-by: Brian Walsh <brian@walsh.ws>
    ---

    diff -ur a/drivers/base/core.c b/drivers/base/core.c
    --- a/drivers/base/core.c 2006-07-10 13:26:00.000000000 -0400
    +++ b/drivers/base/core.c 2006-07-10 13:32:58.000000000 -0400
    @@ -307,6 +307,10 @@
    if ((error = kobject_add(&dev->kobj)))
    goto Error;

    + /* notify platform of device entry */
    + if (platform_notify)
    + platform_notify(dev);
    +
    dev->uevent_attr.attr.name = "uevent";
    dev->uevent_attr.attr.mode = S_IWUSR;
    if (dev->driver)
    @@ -361,10 +365,6 @@
    list_add_tail(&dev->node, &dev->class->devices);
    up(&dev->class->sem);
    }
    -
    - /* notify platform of device entry */
    - if (platform_notify)
    - platform_notify(dev);
    Done:
    kfree(class_name);
    put_device(dev);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-10 21:53    [W:0.021 / U:90.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site