Messages in this thread Patch in this message | | | Date | Mon, 10 Jul 2006 16:31:30 +0100 | Subject | Re: [PATCH 6/6] Account for memmap and optionally the kernel image as holes | From | (Mel Gorman) |
| |
On (10/07/06 12:30), David Howells didst pronounce: > Mel Gorman <mel@csn.ul.ie> wrote: > > > +unsigned long __initdata dma_reserve; > > Should this be static? Or should it be predeclared in a header file > somewhere? >
It should be static as it's set by set_dma_reserve(). Thanks.
diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.17-mm6-106-account_kernel_mmap/mm/page_alloc.c linux-2.6.17-mm6-107-fixstatic/mm/page_alloc.c --- linux-2.6.17-mm6-106-account_kernel_mmap/mm/page_alloc.c 2006-07-10 15:55:09.000000000 +0100 +++ linux-2.6.17-mm6-107-fixstatic/mm/page_alloc.c 2006-07-10 16:03:26.000000000 +0100 @@ -87,7 +87,7 @@ int min_free_kbytes = 1024; unsigned long __meminitdata nr_kernel_pages; unsigned long __meminitdata nr_all_pages; -unsigned long __initdata dma_reserve; +static unsigned long __initdata dma_reserve; #ifdef CONFIG_ARCH_POPULATES_NODE_MAP /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |