lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()
On 10/07/06, Christoph Hellwig <hch@infradead.org> wrote:
> > -static inline void uid_hash_insert(struct user_struct *up, struct list_head *hashent)
> > +static inline void uid_hash_insert(struct user_struct *_up, struct list_head *hashent)
> > {
>
> Please never use such ugly names. A simply 'u' as variable name would do it
> instead in most places.
>
Ok, will do.
Thank you for the feedback.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-10 16:55    [W:0.033 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site