lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    Krzysztof Halasa wrote:
    > "Antonino A. Daplas" <adaplas@pol.net> writes:
    >
    >>> You're right here, I don't know why I assumed DEPENDS does it
    >>> automatically.
    >> Use select.
    >
    > It has a known problem - if the "selected" thing changes (requires
    > another option etc) things are screwed. With "depends on", you don't
    > have to track such changes.
    >
    > While near selects (in the same build directory) are IMHO ok, far
    > ones are not.
    >
    > I think it would be different if trying to select something which
    > can't be selected automatically resulted in a warning. I think
    > I have to look at it then, but for now I'll use something like
    > "depends on (FB_CIRRUS=m && I2C && I2C_ALGOBIT) ||
    > (FB_CIRRUS=y && I2C=y && I2C_ALGOBIT=y)".

    Well if the i2c code happens to depend on another module, I hope
    that Jean would warn us in a timely manner :-). And even if Jean
    failed to do so, it would immediately result in a compile
    error/warning which should lead to an easy fix.

    I still prefer 'select' just because it's easier to parse, but
    either way is okay, though your method takes me a few more seconds
    to understand.

    Tony
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-10 16:31    [W:0.032 / U:62.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site