Messages in this thread | | | Date | Mon, 10 Jul 2006 15:53:21 +1000 | From | Nathan Scott <> | Subject | Re: [PATCH] blktrace: readahead support |
| |
On Mon, Jul 10, 2006 at 12:46:03AM -0500, Milton Miller wrote: > > +#define trace_ahead_bit(rw) \ > > + (((rw) & (1 << BIO_RW_AHEAD)) << (BIO_RW_AHEAD - 0)) > ... > I think the shift should be << (2 - BIO_RW_AHEAD).
Quite possibly. As long as it ends up in slot 4 in that array still.. which it will.
cheers.
-- Nathan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |