Messages in this thread |  | | From | Andi Kleen <> | Subject | Re: [PATCH 01/14] Per zone counter functionality | Date | Fri, 9 Jun 2006 06:28:57 +0200 |
| |
> +/* > + * For an unknown interrupt state > + */ > +void mod_zone_page_state(struct zone *zone, enum zone_stat_item item, > + int delta) > +{ > + unsigned long flags; > + > + local_irq_save(flags); > + __mod_zone_page_state(zone, item, delta); > + local_irq_restore(flags);
It would be nicer to use some variant of local_t - then you could do that without turning off interrupts (which some CPUs like P4 don't like)
There currently is not 1 byte local_t but it could be added.
Mind you it would only make sense when most of the calls are not already with interrupts disabled.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |