Messages in this thread | | | Subject | Re: [PATCH 01/14] Per zone counter functionality | From | Peter Zijlstra <> | Date | Fri, 09 Jun 2006 11:22:13 +0200 |
| |
On Thu, 2006-06-08 at 21:00 -0700, Andrew Morton wrote: > On Thu, 8 Jun 2006 16:02:44 -0700 (PDT) > Christoph Lameter <clameter@sgi.com> wrote:
> > +#ifdef CONFIG_SMP > > +void refresh_cpu_vm_stats(int); > > +void refresh_vm_stats(void); > > +#else > > +static inline void refresh_cpu_vm_stats(int cpu) { }; > > +static inline void refresh_vm_stats(void) { }; > > +#endif > > do {} while (0), please. Always. All other forms (afaik) have problems. > In this case, > > if (something) > refresh_vm_stats(); > else > foo(); > > will not compile.
It surely will, 'static inline' does not make it less of a function. Although the trailing ; is not needed in the function definition.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |