Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: 2.6.18 -mm merge plans | Date | Fri, 09 Jun 2006 18:39:24 -0600 |
| |
"Serge E. Hallyn" <serue@us.ibm.com> writes:
> Quoting Eric W. Biederman (ebiederm@xmission.com): >> If you want to help with the bare pid to struct pid conversion I >> don't have any outstanding patches, and getting that done kills >> some theoretical pid wrap around problems as well as laying the ground >> work for a simple pidspace implementation. >> >> Eric > > Is this the sort of thing you are looking for? Is this worthwhile for > kernel_threads, or only for userspace threads - i.e. do we expect kernel > threads to live?
For kernel threads we should simply be able to use their task struct.
In this instance we have hit upon a different problem. Anything using the kernel_thread API instead of the kthread api needs to be updated.
The basic problem is that for kernel_threads can show up inside of containers.
We can fix that by updating daemonize or we can simply universally use the kthread api. Since the kernel_thread api is deprecated because of these kinds of reasons what really makes sense is to work on the transition to the kthread api.
> If we do want to do this for kernel threads, then I assume that > eventually we'll want to change kernel_thread() itself. I actually > started to do that earlier, but of course that way every user would > have to be changed in the same patch :) > > Subject: [PATCH] struct pid: convert ieee1394 to hold struct pid > > ieee1394 driver caches pid_t's for kernel threads. Switch to > holding a reference to a struct pid. This prevents concern > about the cached pid pointing to the wrong process after the > kernel thread dies and pids wrap around. > > Signed-off-by: Serge Hallyn <serue@us.ibm.com>
Ok a couple of comments.
As I recall there are some pretty sane ways of going from struct pid to a task_struct and then we can use things like group_send_sig.
But otherwise you seem to be using struct pid ok.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |