Messages in this thread | | | Date | Thu, 8 Jun 2006 11:02:30 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] limit power budget on spitz |
| |
Hi!
> > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > > index acde886..1d8b58c 100644 > > --- a/drivers/usb/host/ohci-pxa27x.c > > +++ b/drivers/usb/host/ohci-pxa27x.c > > @@ -185,6 +185,13 @@ int usb_hcd_pxa27x_probe (const struct h > > /* Select Power Management Mode */ > > pxa27x_ohci_select_pmm(inf->port_mode); > > > > + if (machine_is_spitz()) { > > + /* Warning, not coming from any official docs. But > > + * spitz is unable to properly power wireless card > > + * claiming 500mA -- usb interface work but wireless > > + * does not. */ > > + hcd->power_budget = 250; > > + } > > ohci_hcd_init(hcd_to_ohci(hcd)); > > > > retval = usb_add_hcd(hcd, pdev->resource[1].start, SA_INTERRUPT); > > Should this value not be specified by the platform in the platform data > rather than a set of machine_is_xxx statements in the driver itself? I > already put most of the infrastructure for that into place.
Well, it has quite few users now, and this is how it works in ohci-omap. Yes, if we get more of such hooks, it probably needs to be moved to platform data...
> I also strongly suspect the power supply on the device is limited to > 150mA.
Thanks! Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |