Messages in this thread |  | | Date | Wed, 7 Jun 2006 22:01:18 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH] use unlikely() for current_kernel_time() loop |
| |
On 08 Jun 2006 04:28:12 +0200 Andi Kleen <ak@suse.de> wrote:
> Andreas Dilger <adilger@clusterfs.com> writes: > > > Hello, > > I just noticed this minor optimization. current_kernel_time() is called > > from current_fs_time() so it is used fairly often but it doesn't use > > unlikely(read_seqretry(&xtime_lock, seq)) as other users of xtime_lock do. > > Also removes extra whitespace on the empty line above. > > It would be better to put the unlikely into the read_seqretry I guess. >
yup. But it'd be good to check that this actually causes the compiler to do the right thing, rather than simply ignoring it.
I'm not sure how one would do that though. I guess compare before-and-after assembly code, work out if "after" is better.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |