Messages in this thread | | | Date | Thu, 8 Jun 2006 18:09:13 +0100 | From | Russell King <> | Subject | Re: [PATCH] limit power budget on spitz |
| |
On Thu, Jun 08, 2006 at 10:22:50AM +0100, Richard Purdie wrote: > Hi, > > On Thu, 2006-06-08 at 11:02 +0200, Pavel Machek wrote: > > > > + if (machine_is_spitz()) { > > > > + /* Warning, not coming from any official docs. But > > > > + * spitz is unable to properly power wireless card > > > > + * claiming 500mA -- usb interface work but wireless > > > > + * does not. */ > > > > + hcd->power_budget = 250; > > > > + } > > > > > > > > > Should this value not be specified by the platform in the platform data > > > rather than a set of machine_is_xxx statements in the driver itself? I > > > already put most of the infrastructure for that into place. > > > > Well, it has quite few users now, and this is how it works in > > ohci-omap. Yes, if we get more of such hooks, it probably needs to be > > moved to platform data... > > Just because the omap does it that way, doesn't mean it can't be done > better ;-). I've also just realised the above doesn't account for akita > or borzoi. Since the hardware is identical in this area, the same > changes should be applied for those machines. If we use the platform > device/data approach, we don't have this problem as they all use the > same platform device :)
So what do folk want me to do? Blindly merge the patch (hint: it's still in the incoming queue...)
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |