lkml.org 
[lkml]   [2006]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] Make Intel e1000 driver legacy I/O port free
    Jeff Garzik wrote:
    > Kenji Kaneshige wrote:
    >
    >>No, those tasks are done through pci_enable_device_bars() called from
    >>pci_enable_device() actually. In addition, I made small changes to
    >>pci_enable_device() and pci_enable_device_bars() in another patch ([PATCH 1/4]).
    >>Now pci_enable_device_bars() just call pci_enable_device_bars() like below:
    >>
    >>int
    >>pci_enable_device(struct pci_dev *dev)
    >>{
    >> int err = pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1);
    >> if (err)
    >> return err;
    >> return 0;
    >>}
    >
    >
    > You'll likely break IDE with such a change, which I also NAK. You can't
    > just blindly do everything that pci_enable_device() does in IDE, which
    > was the entire reason why pci_enable_device_bars() was added by Alan in
    > the first place.
    >

    Could you tell me what will be broken by my change? I only moved the
    following two lines from pci_enable_device() to pci_enable_device_bars().

    pci_fixup_device(pci_fixup_enable, dev);
    dev->is_enabled = 1;

    Thanks,
    Kenji Kaneshige

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-08 19:06    [W:0.033 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site