lkml.org 
[lkml]   [2006]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][RFC] Clean-up: TASK_UNMAPPED_BASE and mmap_base
From
Date
On Tue, 2006-06-06 at 21:33 -0400, John Richard Moser wrote:
> This patch applies to 2.6.17-rc6 to replace several occurrences of
> TASK_UNMAPPED_BASE with current->mm->mmap_base, mm->mmap_base, or base,
> as appropriate.
>
> I am not entirely sure what all of the code I messed with is doing, to
> be quite honest. Code that seemed to be initializing a task and setting
> up the mmap() base I left with TASK_UNMAPPED_BASE; code that seemed to
> be trying to figure out what the mmap() base was I replaced with
> mm->mmap_base.
>
> Because of this, I may have made a couple errors. Could I get some
> comments on whether any of this is dirty and why? I'll make appropriate
> changes and re-submit. This only took 2 hours anyway.
>

now if you put your patch inline you'd get comments in detail

but you missed that some of the places where this is used is the
fallback in case the per-task value doesnt result in a good memory hole
found.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-08 14:27    [W:0.037 / U:10.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site