lkml.org 
[lkml]   [2006]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix generic HDLC synclink mismatch build error
On Wed, 07 Jun 2006 19:23:21 -0500 Paul Fulghum wrote:

> Roman Zippel wrote:
> > Hi,
> >
> > On Wed, 7 Jun 2006, Paul Fulghum wrote:
> >
> >
> >>-#ifdef CONFIG_HDLC_MODULE
> >>+#if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
> >> #define CONFIG_HDLC 1
> >> #endif
> >
> >
> > Please don't define your own config symbols, just use Kconfig for this,
> > simply remove the prompts from your earlier patch and add the dependecies
> > as Randy suggested.
>
> Randy's patch defines config symbols, so I don't know what you are getting at.

Yes, but in the config language, not inside a driver source file.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-08 04:38    [W:0.042 / U:26.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site