lkml.org 
[lkml]   [2006]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] use unlikely() for current_kernel_time() loop
Hello,
I just noticed this minor optimization. current_kernel_time() is called
from current_fs_time() so it is used fairly often but it doesn't use
unlikely(read_seqretry(&xtime_lock, seq)) as other users of xtime_lock do.
Also removes extra whitespace on the empty line above.

Signed-off-by: Andreas Dilger <adilger@clusterfs.com>


--- ./kernel/time.c.orig 2006-05-08 15:40:43.000000000 -0600
+++ ./kernel/time.c 2006-06-07 11:24:49.000000000 -0600
@@ -424,9 +424,9 @@ inline struct timespec current_kernel_time

do {
seq = read_seqbegin(&xtime_lock);
-
+
now = xtime;
- } while (read_seqretry(&xtime_lock, seq));
+ } while (unlikely(read_seqretry(&xtime_lock, seq)));

return now;
}
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-07 19:39    [W:0.052 / U:7.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site