Messages in this thread | | | Date | Tue, 6 Jun 2006 14:20:22 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] fix missing hdlc symbols for synclink drivers |
| |
On Tue, 06 Jun 2006 23:09:42 +0200 Krzysztof Halasa wrote:
> Paul Fulghum <paulkf@microgate.com> writes: > > > If I took that approach then you could never > > use the synclink drivers without generic HDLC. > > > > The synclink drivers can be used independent of > > the generic HDLC or with generic HDLC depending > > on space requirements and application. > > Ah, now I understand. Anyway, the Makefile is not related to the problem. > > > If you can provide a patch that continues allowing > > that level of flexibility in a way more to > > your liking, then please post it and I'll have a look. > > I think I would modify the conditionals in drivers/char/synclink.c > - to assume that generic HDLC is not present if CONFIG_SYNCLINK=y > and CONFIG_HDLC=m. I would even put a user-visible comment in the > *config (like the one in generic HDLC menu if you have no X.25/LAPB). > > I.e., I would probably change: > > #ifdef CONFIG_HDLC_MODULE > #define CONFIG_HDLC 1 > #endif > > into something like: > > #if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE) > #define CONFIG_HDLC 1 > #endif
So SYNCLINK has different capabilities depending on whether HDLC=m or HDLC=y ?? Makes no sense to me, but I'll leave it to you and Paul.
> plus that comment in Kconfig. > > (Not sure if the other synclink*.c files are relevant and need similar > changes). > -- > Krzysztof Halasa
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |